Conversation
Maed223
force-pushed
the
update-stacks-plugin-binary-download-to-accomodate-crt-zip
branch
from
6dad9d3 to
bab03c3
Compare
Maed223
added
the
no-changelog-needed
Maed223
force-pushed
the
update-stacks-plugin-binary-download-to-accomodate-crt-zip
branch
from
bab03c3 to
e16c5f6
Compare
Maed223
force-pushed
the
update-stacks-plugin-binary-download-to-accomodate-crt-zip
branch
from
9bd9d76 to
e16c5f6
Compare
liamcervante
approved these changes
Jun 5, 2025
Maed223
deleted the
update-stacks-plugin-binary-download-to-accomodate-crt-zip
branch
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #37192
Description
There was an overlooked detail in the binary manager for plugins, in that we didn't properly accommodate the CRT style of releases. In the CRT release process there is a
LICENSE.txtthat we didn't account for, leading to the decompress failing because the file limit was set too low. Additionally there is some file path adjustments made to properly access the binary.For testing, using a local build of this branch, you should be able to run
terraform stacksTarget Release
1.13.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry